Make hardcoded strings translatable. #21810
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Wraps previously hardcoded strings in {ts} in Smarty .tpl files.
Before
Some strings in .tpl files were hardcoded.
After
Strings are translatable.
Technical Details
I used a set of regex searches of style
<span[^>]*>(\s*)[a-z]
to find these untranslated strings, having spotted the first few whilst using Civi. I'm sure a few other hardcoded strings are still hanging around after this change.