Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make hardcoded strings translatable. #21810

Merged

Conversation

braders
Copy link
Contributor

@braders braders commented Oct 12, 2021

Overview

Wraps previously hardcoded strings in {ts} in Smarty .tpl files.

Before

Some strings in .tpl files were hardcoded.

After

Strings are translatable.

Technical Details

I used a set of regex searches of style <span[^>]*>(\s*)[a-z] to find these untranslated strings, having spotted the first few whilst using Civi. I'm sure a few other hardcoded strings are still hanging around after this change.

Wraps previously hardcoded strings in {ts} in Smarty .tpl files.
@civibot civibot bot added the master label Oct 12, 2021
@civibot
Copy link

civibot bot commented Oct 12, 2021

(Standard links)

@mattwire
Copy link
Contributor

Looks great!

@eileenmcnaughton eileenmcnaughton merged commit 5556094 into civicrm:master Oct 12, 2021
@braders braders deleted the feature/missing-translations branch October 12, 2021 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants