System status checks only shows 25 messages

[mattwire]

Overview

Because this page uses API3 and doesn't specify limit=0 it's only showing the first 25 status checks. That's particularly bad because they get sorted by severity and it's the lowest severity first meaning you won't see the real problems if you have more than 25 checks.

Before

Only first 25 (lowest severity) system status check messages are shown.

After

All system status check messages are shown.

Technical Details

Add limit=0

Comments

@mlutfy I'm surprised if you didn't already see this - I'm using an extension based on your symbiotic one that does lot's of extra system checks.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

You've got to be kidding me.

[mlutfy]

Oh, that explains some odd behaviours I've seen indeed.

Without the patch:

With the patch:

@colemanw You'd be surprised how many hours of debugging we save with these extra monitoring checks:

• Site added with a language not supported by the system, and devs wonder why it's not displaying in the right language
• Devs doing dump/restore of MySQL tables and deleting all the Foreign Keys
• Email quotas, high rate of bounces, invalid sending domains, ...
• we also monitor for some obscure known bugs that we don't really know how they happen, but they sometimes happen.

It adds up pretty quickly :)

[colemanw]

@mlutfy those checks look useful. My comment wasn't directed at those; more like "you gotta be kidding me, when are we ever going to stop getting bitten by the limit=25 gotcha!"