Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes duplicate replace on event fee amount. #21739

Merged
merged 1 commit into from
Oct 6, 2021

Conversation

agileware-justin
Copy link
Contributor

Removes duplicate replace on event fee amount. Noticed this one whilst reviewing #21738

@civibot
Copy link

civibot bot commented Oct 6, 2021

(Standard links)

@civibot civibot bot added the master label Oct 6, 2021
@agileware-justin
Copy link
Contributor Author

agileware-justin commented Oct 6, 2021

@eileenmcnaughton was this meant to be a membership related token instead? Looks like a copy/paste error.

@eileenmcnaughton
Copy link
Contributor

@agileware-justin yeah - I was just thinking it looks like a copy & paste error & wondering what it should have been...

@eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton
Copy link
Contributor

Hmm - 5 here, 5 there, a duplicate here, a different duplicate there - maybe there were only 4 :-)

@agileware-justin
Copy link
Contributor Author

agileware-justin commented Oct 6, 2021

Actually, there's multiple upgraders to check for missing upgrades... ugh.

function upgrade_5_41_alpha1 has the missing contribution upgrade tokens,

@eileenmcnaughton
Copy link
Contributor

@agileware-justin yeah & also - not all paths had the same tokens - ie. originally (for example not necessarily this one) pdf letters supported contribution.status and reminders supported contribution.contribution_status_id

I tried to put them in the upgrader as I worked through them & also in the dev docs - but obviously not without making mistakes!

@eileenmcnaughton eileenmcnaughton merged commit ff07bd5 into civicrm:master Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants