Skip to content

APIv4 - Give every SQL expression a title #21691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2021

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Oct 1, 2021

Overview

Fixes a bug in Afform where it would crash trying to get the title of SQL Equations
on search display forms.

Before

  1. Create a search display that uses an equation in a column.
  2. Try to create an afform for it.
  3. Crash

After

Works.

Technical Details

Just to avoid confusion about which Sql expressions have a title and which do not, I added one for all of them.

Fixes a bug in Afform where it would crash trying to get the title of SQL Equations
on search display forms.
@civibot
Copy link

civibot bot commented Oct 1, 2021

(Standard links)

@civibot civibot bot added the master label Oct 1, 2021
@eileenmcnaughton
Copy link
Contributor

I replicated this & confirmed this fixes

@eileenmcnaughton eileenmcnaughton merged commit ed72890 into civicrm:master Oct 2, 2021
@eileenmcnaughton eileenmcnaughton deleted the sqlExprTitles branch October 2, 2021 07:01
eileenmcnaughton added a commit to eileenmcnaughton/civicrm-core that referenced this pull request Oct 3, 2021
APIv4 - Give every SQL expression a title
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants