Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF] Extract getRedirectUrl method #21687

Merged
merged 1 commit into from
Oct 1, 2021
Merged

[REF] Extract getRedirectUrl method #21687

merged 1 commit into from
Oct 1, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

[REF] Extract getRedirectUrl method

Before

Long chunk of code

After

Extracted

Technical Details

Basic extraction

Comments

@civibot
Copy link

civibot bot commented Oct 1, 2021

(Standard links)

@civibot civibot bot added the master label Oct 1, 2021
@demeritcowboy
Copy link
Contributor

The redirect doesn't work properly but I don't think it's because of the PR - it was problematic before.

@demeritcowboy demeritcowboy merged commit 98dbbb9 into civicrm:master Oct 1, 2021
@eileenmcnaughton eileenmcnaughton deleted the case1 branch October 1, 2021 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @demeritcowboy