Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SelfSvcUpdate.php #21679

Merged
merged 1 commit into from
Sep 30, 2021
Merged

Update SelfSvcUpdate.php #21679

merged 1 commit into from
Sep 30, 2021

Conversation

Detsieber
Copy link
Contributor

Changing this text is necessary for internationalization, because otherwise we get an ambigous translation in some languages

Overview

Simple change of "cancel" to "cancel registration"

Before

"cancel" won't give a meaningful translation, at least in german.

After

"cancel registration" remains meaningful in english, but works better in other languages.
This string already exists in CRM/Event/Form/Registration/ParticipantConfirm.php, so most probably transifex already has the translation available for most languages.

Technical Details

n.a.

Comments

n.a.

Changing this text is necessary for internationalization, because otherwise we get an ambigous translation in some languages
@civibot
Copy link

civibot bot commented Sep 30, 2021

(Standard links)

@eileenmcnaughton
Copy link
Contributor

Makes sense - ping @mlutfy

@eileenmcnaughton eileenmcnaughton merged commit 4c7f5e6 into civicrm:master Sep 30, 2021
@Detsieber Detsieber deleted the patch-2 branch October 1, 2021 05:43
@mlutfy
Copy link
Member

mlutfy commented Oct 1, 2021

Yep, thanks @Detsieber

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants