[REF] Separate contact tokens from 'tokenCompatSubscriber'

[eileenmcnaughton]

Overview

[REF] Separate contact tokens from 'tokenCompatSubscriber'

This just moves code around - loads of testing - but it separates
the contact entity stuff from the 'compat' - presumably 'compatibility'
subscriber.

Before

The contact token code has been separated from the 'compat' code within the class but is still in the same class

After

Token code gets it's own special class

Technical Details

We should consider renaming 'tokenCompatSubscriber' as a follow up - even 'tokenCompatibilitySubscriber' would be better as it is less English-speaking centric (dictionary words can be looked up if you don't know them). It's really a TokenSmartyHandler these days

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@colemanw this is why I wanted to hustle on the other - because I wanted to move code around. The tests I ran locally passed but there are a lot of tests in the full suite so in another 1.75 hours we will know...

[colemanw]

Ok