Skip to content

Remove broken code #21602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2021
Merged

Remove broken code #21602

merged 1 commit into from
Sep 24, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Remove broken code

Before

Code call to a non-existent function

image

After

poof

Technical Details

I don't even know what this is supposed to do - but since the function
has been missing for our entire git history it must
be unreachable.

This link is to the code in that file right back in 2013 when we imported from svn

https://github.com/civicrm/civicrm-core/blob/4d5c2eb510a6be0017085d1f8dae09495e28e74b/CRM/Contact/BAO/SearchCustom.php

Comments

I don't even know what this is supposed to do - but since the function
has been missing for our entire git history it must
be unreachable.

https://github.com/civicrm/civicrm-core/blob/4d5c2eb510a6be0017085d1f8dae09495e28e74b/CRM/Contact/BAO/SearchCustom.php
@civibot
Copy link

civibot bot commented Sep 24, 2021

(Standard links)

@civibot civibot bot added the master label Sep 24, 2021
@colemanw
Copy link
Member

I can confirm the function civiMailSQL doesn't exist, so removing this makes sense.

@seamuslee001 seamuslee001 merged commit e2e982d into civicrm:master Sep 24, 2021
@seamuslee001 seamuslee001 deleted the broke branch September 24, 2021 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants