dev/core#2493 Add support for money laundry in getSubmittedValue
#21555
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This ensures that any money fields retrieved by
getSubmittedValue
arein a machine usable format.
https://lab.civicrm.org/dev/core/-/issues/2493#note_65321
Before
You might clean the money fields post submit but if you then access them using our increasingly-preferred helper you'll get the unclean version
After
The helper will launder your money
Technical Details
We've been switching to this function rather than 'passing around arrays'
but we need to ensure this function is returning clean money to
prevent regressions.
Comments
This relies on
submittableMoneyFields
being defined - which is fairly uniformly true in back office forms but needs work in front end forms