Test tearDown fixes #21548
Merged
Test tearDown fixes #21548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
| @@ -35,10 +40,6 @@ public function testStoreCountry() { | |||
| ]; | |||
|
|
|||
| CRM_Core_BAO_CustomValueTable::store($params, 'civicrm_contact', $contactID); | |||
|
|
|||
| $this->customFieldDelete($customField['id']); | |||
There was a problem hiding this comment.
moved to tearDown which is more correct
Fixes places where parent:tearDown not called and civicrm_file & civicrm_entity_file not truncated Also note - increasing use of fail() rather than allowing exceptions to bubble up in test functions in order to not let tearDown be such a distraction & require annotation
eileenmcnaughton
force-pushed
the
cleanup
branch
from
fcfbca4 to
d706c14
Compare
|
well this seems to work @eileenmcnaughton is this mergable now? |
|
@seamuslee001 yeah - then I'll retry the other |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Test tearDown fixes
Before
Can't figure out what is leaving 'civicrm_file' & 'civicrm_entity_file' records behind
After
Have tracked down some ...
Technical Details
Fixes places where parent:tearDown not called and civicrm_file &
civicrm_entity_file not truncated
Also note - increasing use of fail() rather than allowing
exceptions to bubble up in test functions in order
to not let tearDown be such a distraction & require annotation
Comments