Fix issues with case sorting/searching from case dashboard #21514
+10
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
Thanks will check it out. |
|
I haven't looked closely yet but this has a weird effect on the Cases tab on a contact. It now shows two columns for Next Scheduled Date instead of one for Scheduled and one for Recent, and both are now blank. |
mattwire
added
the
needs-work-not-review-ready
|
Maybe a good start but going to close this one until someone has time to make it work. The lab tickets link here already. |
mattwire
force-pushed
the
1624_2319_casedashboard
branch
from
930fa28 to
0f73dba
Compare
mattwire
removed
the
needs-work-not-review-ready
|
Hi @demeritcowboy I've just updated/refreshed this and updated the description above. I don't see any of the issues you mentioned introduced anymore and this should be an overall improvement in stuff actually working! |
|
Thanks will take a look. |
|
I think this seems an ok step (i.e. sorting doesn't work now so just remove the ability to sort). These all seem ok:
|
|
Thanks @demeritcowboy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes https://lab.civicrm.org/dev/core/-/issues/1624: Case Dashboard/Dashlet gives datatables error if sort by type or status:
Now works!
"Fixes" https://lab.civicrm.org/dev/core/-/issues/2319: Network error when trying to sort results by 'Next Scheduled date':
Disables sorting on most recent / next scheduled. This is better than before where it allows you to sort but then triggers a DB error whenever you try. It looks more complex to actually make the sort work because of the complexity of the query and dependencies internally in CiviCRM.
Before
500 / network error when sorting by status/type.
After
Sorting/searching works without error.
Technical Details
See lab issues
Comments
@demeritcowboy