Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchKit - Correctly process filters passed through Afform from js #21485

Merged
merged 1 commit into from
Sep 16, 2021

Conversation

colemanw
Copy link
Member

Overview

Fixes a regression caused by #21388

Before

Could not pass filters as javascript variables to search displays.

After

Works.

@civibot
Copy link

civibot bot commented Sep 15, 2021

(Standard links)

@civibot civibot bot added the master label Sep 15, 2021
@colemanw
Copy link
Member Author

retest this please

@eileenmcnaughton
Copy link
Contributor

@colemanw this is code that has just changed so ok to change again - but I don't understand how to be sure that nothing insecure is being permitted here as it seems to loosen restrictions

@colemanw
Copy link
Member Author

colemanw commented Sep 16, 2021

@eileenmcnaughton it does loosen restrictions (back to the way it was pre-regression) but still within the bounds of the Afform. The security comes from the fact that only filters present on the Afform are allowed. We can trust the Afform because it is stored on the server, not coming from the client.

@eileenmcnaughton
Copy link
Contributor

Ok....

@eileenmcnaughton eileenmcnaughton merged commit 600977f into civicrm:master Sep 16, 2021
@eileenmcnaughton eileenmcnaughton deleted the fixFilter branch September 16, 2021 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants