dev/core#2790 Move rest of pdfCommon functionality to the trait #21479
Conversation
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
case_rep2
branch
from
5ce06d1 to
af1514b
Compare
| // By calling the cached function we can get this down to 1 | ||
| $this->assertEquals(4, $this->hookTokensCalled); |
There was a problem hiding this comment.
Test change reflects one less call to the token processor - from the comments less is more. This will be the removal of the 'categories' call
eileenmcnaughton
force-pushed
the
case_rep2
branch
from
af1514b to
0ceb63d
Compare
|
@demeritcowboy I've just rebased this with the other PR merged - so we can see if it fails on that screen on the test sites - once built |
|
Both this and #21489 give error 500's on the PR test sites. Do we know the filename of the web server error log on these sites? We could do file_get_contents() in the PR and display it (anywhere convenient, since we'd have to go to another page later anyway AFTER the crash to get it). |
|
@demeritcowboy I just tried with a different PR altogether & the test site gives 500 errors on that too |
|
@mlutfy how do we check this out - on any PR test site - but NOT on the demo site or our locals the following results in a 500 error
|
|
@demeritcowboy - it could be something long-standing like this even https://stackoverflow.com/questions/34599266/pdf-generation-results-in-err-invalid-response-in-chrome |
|
@demeritcowboy Actually I think this might be it #21504 |
|
test this please |
|
Yay! I'll try to look at at least one of the PRs tonight. It's a busy week. |
|
thanks @demeritcowboy - really appreciate all your help! |
Overview
dev/core#2790 Move rest of pdfCommon functionality to the trait
Before
Functionality on the static PDFCommon
After
Moved to the trait
Technical Details
After this only the form rule is used from the shared class. I will leave that a bit longer as I have another PR that is adding deprecations to it open but from this I can switch to cleaning it up
Comments
Includes #21478