[Ref] Cleanup on SelectValues::contributeTokens

[eileenmcnaughton]

Overview

[Ref] Cleanup on SelectValues::contributeTokens

This has 100% test cover in the ByTypeTest::testTokenRendering test

Before

6 lines of code

After

2

Technical Details

Now that the Contribute token processor class is 'listening' we can do this simplification

The change means we no longer need the recently-added function
to be public & hence it is switched to protected.

Note this is the same as the equivalent contactTokens function

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

Only 100% cover? Couldn't we get 110% like my gym coach was always asking for?