dev/core#2835 - Activity export broken in 5.41

[demeritcowboy]

Overview

https://lab.civicrm.org/dev/core/-/issues/2835

Before

1. Find Activities
2. Select a couple and from the dropdown choose export.
3. You're now on a different screen, not the export screen - which screen seems to depend where you were before.
4. Warning: Illegal offset type in CRM_Activity_StateMachine_Search->__construct() (line 41 of ...\CRM\Activity\StateMachine\Search.php).

After

Works

Technical Details

This seems intended to be a cast to array not a nested array:

20eb1cf#diff-0118f13b1d17a95ba175eca5956f83bcf00341a38d4fa9741f275ff44e8252b3R160

Comments

Before the patch the unit test fails for EXPORT, EMAIL, and BATCH.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

thanks @demeritcowboy

[demeritcowboy]

Thanks. I guess I'll put up a 5.41 version in case there's a 5.41 release.