[REF] Extract function to getDomainTokens #21416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
commented
Sep 9, 2021
| $domain = CRM_Core_BAO_Domain::getDomain(); | ||
| } | ||
| else { | ||
| $domain = new CRM_Core_BAO_Domain(); |
There was a problem hiding this comment.
honestly - we are being pretty coy not just loading it in the first place but maybe it will save a query...
eileenmcnaughton
force-pushed
the
dom_toke
branch
from
f3bdbf6 to
2e6ceaf
Compare
This caches the whole token set by domain+locale+html rather than just part. I am thinking about where this should do - on the BAO_Domain class? Or on a token processor class (eventually it would only be called from a token processor class) Test cover in 'BAO_MessageTemplateTest.testDomainTokens'
eileenmcnaughton
force-pushed
the
dom_toke
branch
from
2e6ceaf to
6029977
Compare
|
This works for me |
|
thanks @seamuslee001 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
[REF] Extract function to getDomainTokens
Before
The caching & code for replace domain tokens is just weird
After
A cached array is returned.....
Technical Details
Test cover in
BAO_MessageTemplateTest.testDomainTokensThis caches the whole token set by domain+locale+html rather than just part.
Open questions
Or on a token processor class (eventually it would only be
called from a token processor class)
$htmlin - I left it there for now but I think the token processor would expect to handle that itselfComments