(dev/drupal#163) Session erroneously getting set to NULL on change #21403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
Can one of the admins verify this patch? |
mlutfy
reviewed
Sep 8, 2021
| @@ -171,9 +163,9 @@ public function reset($all = 1) { | |||
| unset($this->_session[$this->_key]); | |||
| } | |||
| else { | |||
| $this->_session = []; | |||
| $this->_session[$this->_key] = []; | |||
| unset($this->_session); | |||
There was a problem hiding this comment.
won't this unset nuke the $_SESSION, because $this->_session is a reference to that variable?
There was a problem hiding this comment.
Yes.
Short Example:
$a = 1;
$b = &$a;
$b++;
echo $a; // display 2
echo $b; // display 2
unset($b);
echo $a; // still display 2
echo $b; // undefined
|
jenkins, test this please |
|
add to whitelist |
|
unfortunately there are very few tests on sessions ( |
|
Test error: |
|
Just noting that we should check that dev/drupal#98 is still fixed as per this PR 9b41879 which added in the session_id handing |
…d by the CRM. Ensures that CRM_Core_Session::_session is still a valid reference to $_SESSION.
GValFr35
force-pushed
the
fix-session-reference-5.40
branch
from
bd83880 to
1fa3e6a
Compare
I wasn't able to easily test d7 yet - but FWIW I was able to masquerade correctly in Drupal 9.1.12 and Masquerade 8.x-2.0-beta4 both before and after this commit, however this does resolve our D9/Commerce checkout-with-login issue. |
mlutfy
added
the
merge ready
|
Looks like |
|
Jenkins retest this please. My only thoughts on this one might be that maybe it allows a malicious module/extension to access non-civi parts of the anonymous session that haven't been cleared which might be from another person previously using the browser. But (a) that's generally true, and is why people are encouraged to close their browser when done on shared machines, and (b) are shared machines even still a thing. |
demeritcowboy
added
merge on pass
and removed
merge ready
|
Jenkins retest this please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Session erroneously getting set to NULL on change (Drupal user login)
Overview
In some cases (ie drupal login / user impersonation (masquerade) / login with externalAuth...), the session id change and CiviCRM remove all the data from $_SESSION, included data out of 'CiviCRM' scope.
Before
After
Technical Details
This issue is a consequence of previous PR from (dev/drupal#98) that managed to fix CRM_Core_Session::_session reference issue. When masquerading with Drupal 7, the $_SESSION change and the CRM_Core_Session::_session doesn't refer the new $_SESSION array.
This PR purposes are: