Fix event custom field tokens in scheduled reminders

[ufundo]

Overview

Fix for rendering Event custom field tokens like {event.custom_123} in scheduled reminders for events

Before

The token processor looks up the value for the custom field using participant id rather than event id.

Generally this will be out of range and so the Scheduled Reminder job fails with Finished execution of Send Scheduled Reminders with result: Failure, Error message: Expected one Event but found 0

[I suppose it's possible it might hit a custom value from a random event in the co-incidence that participant_id matches some other event_id.]

After

{event.custom_123} tokens work as expected.

Technical Details

The line looks like a generalised look up for custom fields on $entity ( which is relevant when repeated in e.g.

civicrm-core/CRM/Member/Tokens.php

Line 88 in 41c0455

$row->customToken($entity, $cfID, $actionSearchResult->entity_id);

) but I'm fairly confident in this context $entity is always 'Event' .

Comments

Looks like there are ambitious plans for TokenProcessor more generally, but hopeful this tiny fix could be useful in the interim.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

I've put up a test here -#21563 - which makes this mergeable