Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] Fix E-notice in Afform unit tests #21345

Merged
merged 1 commit into from
Sep 2, 2021

Conversation

seamuslee001
Copy link
Contributor

Overview

Fixes the following e-notice in Afform unit tests

api_v4_AfformFileUploadTest::testSubmitFile
Trying to access array offset on value of type null

/home/jenkins/bknix-max/build/build-0/web/sites/all/modules/civicrm/ext/afform/core/Civi/Api4/Action/Afform/Get.php:59

Before

E-notice exists in tests on php7.4 and up

After

No E-notice

ping @colemanw

@civibot
Copy link

civibot bot commented Sep 2, 2021

(Standard links)

@civibot civibot bot added the master label Sep 2, 2021
@colemanw
Copy link
Member

colemanw commented Sep 2, 2021

Looks good, thanks @seamuslee001

@seamuslee001 seamuslee001 merged commit 8b59113 into civicrm:master Sep 2, 2021
@seamuslee001 seamuslee001 deleted the fix_afform_test branch September 2, 2021 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants