Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] Fix UpdateSubscriptionTest on php8 by creating a Payment Processor #21324

Merged
merged 1 commit into from
Aug 31, 2021

Conversation

seamuslee001
Copy link
Contributor

Overview

This fixes the following the following test error on php8

CRM_Contribute_Form_UpdateSubscriptionTest::testMail
Failure in api call for Order create:  Error in call to Payment_create : Undefined array key "updateSubscriptionBillingUrl"
#0 /home/jenkins/bknix-edge/build/build-2/web/sites/all/modules/civicrm/CRM/Financial/BAO/Payment.php(189): civicrm_api3('Contribu

Before

Test fails on php8

After

Test passes on php8

ping @eileenmcnaughton

@civibot
Copy link

civibot bot commented Aug 30, 2021

(Standard links)

@civibot civibot bot added the master label Aug 30, 2021
@eileenmcnaughton
Copy link
Contributor

@seamuslee001 I'm OK to merge this to get the test 'out of your hair' - but it should work without a processor

@eileenmcnaughton eileenmcnaughton merged commit b03fd5f into civicrm:master Aug 31, 2021
@eileenmcnaughton eileenmcnaughton deleted the fix_php8_testing branch August 31, 2021 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants