[REF] dev/core#2790 Pre process cleanup on pdf tasks

[eileenmcnaughton]

Overview

[REF] Pre process cleanup on pdf tasks

Before

Three variables are set on the class that were originally set because of shared code but don't seem to make sense

1. $form->_single - this was presumably an enotice fix - if any enotices re-emerge we can fix the right way - by setting a property on the form
2. $form->_contactIds - I believe this was added to support the invoice form - it doesn't make sense to default to writing a letter to your self
3. $form->_emails - this is used in the emails classes but not the pdf classes on searching

After

Poof

Technical Details

Comments

@demeritcowboy this is the clean up I thought needed to be done.... With this done I'll move the preProcess to the trait & move the default setting into it's own function or, more likely, into the setDefaults function already on the trait

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@demeritcowboy also in the same function I'm mystified by

civicrm-core/CRM/Contact/Form/Task/PDFLetterCommon.php

Lines 55 to 66 in 26a7a5a

	$messageText = [];
	$messageSubject = [];
	$dao = new CRM_Core_BAO_MessageTemplate();
	$dao->is_active = 1;
	$dao->find();
	while ($dao->fetch()) {
	$messageText[$dao->id] = $dao->msg_text;
	$messageSubject[$dao->id] = $dao->msg_subject;
	}
	$form->assign('message', $messageText);
	$form->assign('messageSubject', $messageSubject);

• load 'any' message template & assign to the tpl? - it doesn't seem to be used in PDFLetterCommon.tpl or anywhere else I can find....

[demeritcowboy]

I'm reviewing this at the same time as #21276.

And yes I can't see what purpose those messageText/messageSubject tpl vars serve. The same pattern exists in the msgtpltools extension, but I expect was copy/paste since it doesn't seem used there either.

[eileenmcnaughton]

@demeritcowboy ok - so lets remove it - alter this PR - or put up a follow up once this is merged?

[demeritcowboy]

Here would be ok. Either way is fine by me.

[eileenmcnaughton]

@demeritcowboy I've updated to rip out those lines - it's starting to look like less code....

[eileenmcnaughton]

yay - thanks