Fix for new prefetch key #21292
Merged
Fix for new prefetch key #21292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
Retest this please |
Fixes a bug in civicrm#21184 which was masked in the test by the lack of campaigns to load. The ?? operator handles FALSE differently to the ?: operator so this was casting FALSE to TRUE
eileenmcnaughton
force-pushed
the
camps
branch
from
927bfde to
3d9604f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes a bug in
#21184
which was masked in the test by the lack of campaigns to load.
Before
Options still loaded when 'prefetch' is set to FALSE
After
Options not loaded
Technical Details
The ?? operator handles FALSE differently to the ?: operator
so this was casting FALSE to TRUE
Comments
@colemanw