Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CiviCRM Mailing, function unsub_from_mailing has spelling error, "experiement" impacts A/B Mailing unsubscribes #21245

Merged
merged 1 commit into from
Aug 25, 2021

Conversation

agileware-justin
Copy link
Contributor

@agileware-justin agileware-justin commented Aug 24, 2021

CiviCRM Mailing, function unsub_from_mailing has spelling error, "experiement" impacts A/B Mailing unsubscribes

Overview

Spelling mistake in string comparison causes logic to never evaluate.

Before

Logic checks for mailing type "experiement"

After

Logic now checks for mailing type "experiment"

Technical Details

Looks like this was introduced in #15815

Comments

Would be ideal if Jenkins could at least raise a warning for spelling mistakes like this.

Agileware Ref: CIVICRM-1816

…g error, "experiement" impacts A/B Mailing unsubscribes
@civibot
Copy link

civibot bot commented Aug 24, 2021

(Standard links)

@civibot civibot bot added the master label Aug 24, 2021
@eileenmcnaughton eileenmcnaughton merged commit 71a9870 into civicrm:master Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants