Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchKit - Misc bulk action bug fixes #21159

Merged
merged 3 commits into from
Aug 19, 2021

Conversation

colemanw
Copy link
Member

Overview

Minor bug fixes in SearchKit bulk actions.

Before

  • Deleting one or more records with the bulk delete action would still leave them selected, leading to a confusing message about e.g. "2 Contacts selected" even when they were gone:
    image
  • Choosing a date field, e.g. "Birth Date" from the bulk update dialog would show it as a text input rather than date:
    image
  • Clearing a field (by pressing the x in the Select2) would cause javascript errors in the console:
    image

After

All better 🩹

@civibot
Copy link

civibot bot commented Aug 16, 2021

(Standard links)

@civibot civibot bot added the master label Aug 16, 2021
@eileenmcnaughton
Copy link
Contributor

eileenmcnaughton commented Aug 19, 2021

@colemanw this worked fine for me in testing so it's mergeable - I just wanted to highlight that I DID get a console error in testing on the demo site - it looks like the url has a pre-ceding space.

Go ahead & merge if this is unrelated (although ideally fix it or log to gitlab if you do)

image

@colemanw colemanw merged commit 9d8a9c4 into civicrm:master Aug 19, 2021
@colemanw colemanw deleted the fixSearchKitBugs branch August 19, 2021 11:47
@colemanw
Copy link
Member Author

@eileenmcnaughton I'm having a hard time reading that console message but it looks like it's coming from the Drupal "system" module?

@eileenmcnaughton
Copy link
Contributor

@colemanw I went back to the demo site today and didn't see it - only

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants