dev/translation#71 getFullMonthNames: do not rely on the OS for translation

[mlutfy]

https://lab.civicrm.org/dev/translation/-/issues/71

Overview

This kind of question comes up from time to time:
https://civicrm.stackexchange.com/questions/35468/date-in-english-even-when-page-is-set-to-french/40170

"The date is always uses English month and day names regardless of the interface language. How do I fix this?"

The main issue is because currently translating the month name relies on the operating system. The non-English locale must be enabled so that strftime outputs the correct month name (ex: "janvier" not "January").

Most people somewhat control their hosting environment, and can enable it once they know how, but since the default CiviCRM date format uses %B (full month name), it gives a bad first impression. Considering we already have those strings in Transifex, it would be easy to just hardcode the list of months and translate using 'ts'.

Before

Month names are not translated unless a root does dpkg-reconfigure locales and enables the correct xx_YY.utf8 and then restarts fpm or apache. Or a few hours of fiddling on Docker images.

After

Month names are translated out of the box.

Technical Details

Relies on Transifex translations (using ts) instead of strftime.

Comments

I did not bother for now with month abbreviations and other names in CRM_Utils_Date, because they are not used out of the box and would require adding more strings to Transifex.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

There's a couple weird things in the surrounding code but focusing on the important part: How is He-Man translated in other languages? Looks like "Musclor" in French, which unfortunately loses something in translation. But matches up with Skeletor, except Skeletor has muscles too. Wild.

I might suggest though at least switching the function to use Civi::statics instead of the static keyword which doesn't play as nice with unit tests.

[mlutfy]

Good point, updated to use a static.

til: Musclor, scary...I'm only a fan because of old queer memes ;-)