Replace deprecated calls to renderMessageTemplate()
#21121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…` to `CRM_Core_TokenSmarty::render()`
…TokenSmarty::render()`
…to `renderTemplate()`
|
(Standard links)
|
totten
force-pushed
the
master-rendertpl-rem
branch
from
58d7754 to
3151fc5
Compare
|
If jenkins passes this I'm comfortable with it - the edited tests are only a small portion of the tests that cover this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Replace deprecated calls to
renderMessageTemplate().Follow-up to #21115
Before
Calls to
renderMessageTemplate()After
Calls to
TokenSmarty::render()andrenderTemplate().Comments
This merits some
r-runon the PDF and SMS bits.