Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MembershipType.duration and MembershipStatus.name to be required #21119

Merged
merged 1 commit into from
Aug 18, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

This updates these fields to be required as that appears to be the case.

We could alternatively go with a default of 'month' for
MembershipType.duration_unit

Overview

A brief description of the pull request. Keep technical jargon to a minimum. Hyperlink relevant discussions.

Before

What is the old user-interface or technical-contract (as appropriate)?
For optimal clarity, include a concrete example such as a screenshot, GIF (LICEcap, SilentCast), or code-snippet.

After

What changed? What is new old user-interface or technical-contract?
For optimal clarity, include a concrete example such as a screenshot, GIF (LICEcap, SilentCast), or code-snippet.

Technical Details

If the PR involves technical details/changes/considerations which would not be manifest to a casual developer skimming the above sections, please describe the details here.

Comments

Anything else you would like the reviewer to note

@civibot
Copy link

civibot bot commented Aug 13, 2021

(Standard links)

@civibot civibot bot added the master label Aug 13, 2021
This updates these fields to be required as that appears to be the case.

We could alternatively go with a default of 'month' for
MembershipType.duration_unit
@eileenmcnaughton
Copy link
Contributor Author

@seamuslee001 does this seem straight forward to you?

@seamuslee001
Copy link
Contributor

This seems fine to me merging

@seamuslee001 seamuslee001 merged commit 8f48631 into civicrm:master Aug 18, 2021
@seamuslee001 seamuslee001 deleted the member branch August 18, 2021 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants