Respect http_timeout core setting for Guzzle HTTP requests

[mattwire]

Overview

CiviCRM core has a http_timeout setting but USPS, Google geocode and recaptcha is not respecting that timeout and using guzzle default which is 0 (unlimited wait).

Before

Guzzle HTTP requests not respecting core http_timeout setting.

After

Guzzle HTTP requests respecting core http_timeout setting (default 5).

Technical Details

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

• General standards
  • [r-explain] PASS
  • [r-user] PASS
  • [r-doc] PASS
  • [r-run] PASS
    • I couldn't find what screen the setting was on but I could set it with cv. It also has a default of 5.
    • I only tested the google one. I tested it by hacking the google url to be 10.0.0.3.
      • Before: (took about 30 seconds) GuzzleHttp\Exception\ConnectException: "cURL error 28: Failed to connect to 10.0.0.3 port 80: Timed out (see https://curl.haxx.se/libcurl/c/libcurl-errors.html)"
      • After: GuzzleHttp\Exception\ConnectException: "cURL error 28: Connection timed out after 5013 milliseconds (see https://curl.haxx.se/libcurl/c/libcurl-errors.html)"
    • Out of scope but it would be nice to display a nicer error message than the fatal error screen. But it shouldn't come up too often.
• Developer standards
  • [r-tech] PASS
  • [r-code] PASS
  • [r-maint] ?
  • [r-test] PASS

[mattwire]

Thanks @demeritcowboy