[Ref] extract function to getEmailDefaults #21067
Conversation
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
email2
branch
3 times, most recently
from
0f48c1e to
99b696b
Compare
| if (is_numeric(key($form->_fromEmails))) { | ||
| $emailID = (int) key($form->_fromEmails); | ||
| $defaults = CRM_Core_BAO_Email::getEmailSignatureDefaults($emailID); | ||
| } |
There was a problem hiding this comment.
Moving this up seems like it would fix resetting defaults where it seems the intent was to default to the logged in contact, although it seems to do that before anyway so 🤷
This PR seems ok but I am seeing a weird thing on my local so just want to check that out.
There was a problem hiding this comment.
@demeritcowboy ueah I read the setting & then potentially usetting of defaults as a mistake - maybe I'm wrong?
There was a problem hiding this comment.
Wow where did the last 12 hours go? The patch is stale now - EmailCommon doesn't git-apply.
Otherwise if I make those changes manually it seems fine. I'll put up a PR for the thing I was seeing.
There was a problem hiding this comment.
@demeritcowboy should I rebase or will this be superceded & perhaps closable with your patch?
There was a problem hiding this comment.
Sorry it should be rebased - my thing ended up being unrelated.
There was a problem hiding this comment.
ok - rebased
There was a problem hiding this comment.
thanks - merge-on-pass'd
Part of terminally deprecating the EmailCommon class
eileenmcnaughton
force-pushed
the
email2
branch
from
99b696b to
d7b498b
Compare
Overview
[Ref] extract function to getEmailDefaults
Before
This discrete functionality is part of a longer function
After
Separated out
Technical Details
Part of terminally deprecating the EmailCommon class
Comments