dev/core#2730 - Replace fopen call in CRM_Utils_File::isIncludable with one that doesn't need error-supression to avoid problems in php8

[demeritcowboy]

Overview

https://lab.civicrm.org/dev/core/-/issues/2730

Before

One (extreme) way to see the before situation is #21064. Lots of stuff like:

Failure in api call for UFGroup create: fopen(api/v3/UFGroup/Getfields.php): failed to open stream: No such file or directory'

While this is an E_WARNING and doesn't change anything in normal usage in php 8, what does change in php 8 is when you have an error handler that takes the incoming $errno and acts when it has a value of E_WARNING. In php 7, errno is always set to 0 when the error_supression (@) operator is used. In php 8 it passes the actual value in.
(There are other changes, like it also changes the value of error_reporting(), but that doesn't apply to this specifically).

After

Quiet

Technical Details

This should be an equivalent call but at the time the function was written it's possible not all sites had a high enough php version. There's more in the lab ticket if interested.

Comments

Has test, which passed before on the current code so is at least a partial check that there's some equivalence: https://test.civicrm.org/job/CiviCRM-Core-PR/42883/

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

This seems fine to me MOP

[demeritcowboy]

Hmm. The fail is the part of my test I couldn't test on windows. So I need to check is_readable or something separately if it resolves.