Fix Membership.create in BAO to respect passed in status_id

[eileenmcnaughton]

Overview

Fix Membership.create in BAO to respect passed in status_id

Before

• Membership::create overwrites passed in status_id
• Order create forces membership status id for new memberships (good) and renewals (bad)

After

'status_id' respected if it reaches create, renewals not reset to pending

Technical Details

I didn't touch the handling of status_id when I fixed the handling of dates because it caused tests to fail - however, it appears the tests were incorrect. The failure was in the setup and they were creating Memberships with a 'grace' status before the payment was received. So, I did another round of fixing the tests

Comments

@monishdeb I'd really like your help to get this merged before the rc is cut as @artfulrobot has been having issues around this & also because I think there are a few membership bao changes that should ideally be in the same release.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[monishdeb]

I have tested the patch on membership create and renewal and confirmed that it updates the status correctly. The updated unit test captures the workflow accurately. Hence merging

• General standards
  • (r-explain) PASS
  • (r-run) PASS: tested the patch on membership create and renewal and confirmed that it updates the status correctly
• Developer standards
  • (r-tech) PASS
  • (r-code) PASS
  • (r-test) PASS

[eileenmcnaughton]

Yay - thanks @monishdeb !