dev/wordpress#109 fix bug when is_monetary is not checked

[eileenmcnaughton]

Overview

This ensures the paymentProcessor is consistenly on the form regardless of is_monetary being checked

https://lab.civicrm.org/dev/wordpress/-/issues/109 highlights that it has been 'required'
even though we don't understand what it means. This removes that brittleness which we can't
'justify' from a logic point of view

Before

Fatal error if execute real-time monetary transactions is unchecked

After

poof

Technical Details

This fatal error would date back to Dec last year (when a type hint was added to the function ) but has not been reported until now - probably because users, like the code, mostly ignore that checkbox - but we should be tolerant given we don't know why it exists

The code comments indicate that this was thought to be unreachable & given the breakage was not picked up for 6 months I suspect we can remove it

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

Yeh this seems fine to me