APIv4 - Fix calculated fields in bridge entities

[colemanw]

Overview

Fixes a crash-inducing bug in the use of calculated fields on a bridge entity, such as RelationshipCache.is_current which prevented this in SearchKit:

Before

Test fails, search crashes

After

Test passes, search works

Technical Details

It's complicated, trust the unit tests.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@colemanw - I was able to replicate this bug & see if fixed using the url

https://dmaster.localhost/civicrm/admin/search#/create/Contact?params=%7B%22version%22:4,%22select%22:%5B%22id%22,%22display_name%22,%22Contact_RelationshipCache_Contact_01.display_name%22,%22Contact_RelationshipCache_Contact_01.is_current%22%5D,%22orderBy%22:%7B%7D,%22where%22:%5B%5D,%22groupBy%22:%5B%5D,%22join%22:%5B%5B%22Contact%20AS%20Contact_RelationshipCache_Contact_01%22,%22LEFT%22,%22RelationshipCache%22,%5B%22id%22,%22%3D%22,%22Contact_RelationshipCache_Contact_01.far_contact_id%22%5D,%5B%22Contact_RelationshipCache_Contact_01.near_relation:name%22,%22%3D%22,%22%5C%22Child%20of%5C%22%22%5D%5D%5D,%22having%22:%5B%5D%7D

I do have one observation - there are 3 scenarios for is current

1. no relationship exists
2. non-current relation exists
3. current relationship exists

1 & 2 seem to be condensed into 'No' - is this by design?

[colemanw]

Huh. I'm surprised is_current returns anything if there isn't a relationship. Must be because it's a calc field. Let's open a separate issue for that.

[eileenmcnaughton]

@colemanw OK - I'll merge this & let you check that one out separately

[Anatoleallain]

Looks good to me