[NFC/Unit test] ReportTemplateTest - fix tests that assume setup from a separate test

[demeritcowboy]

Overview

Some tests in this file happen to work but shouldn't.

Before

Same

After

Same

Technical Details

When you turn off trigger-based logging, it (properly) doesn't delete all the log records, since the whole point of this logging is to have a forensic-like record of changes. Some of the tests in this file seem to assume a previous test has already turned on logging and that the tables will be there. While those previous tests turn off logging, they don't delete the log tables. So both the tables should be deleted and the later tests should do their own work and start from a clean slate.

If you look higher up around line 257 I've taken my cue from there.

Comments

I'm planning to add a test in here but it fails because of this.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

Looks good to me merging

[demeritcowboy]

Thanks!