Extract getCurrentMembership

[eileenmcnaughton]

Overview

Extract getCurrentMembership

Before

currentMembership not reliably accessable from anywhere in class

After

Extracted

Technical Details

Note I've moved the fixmembershipStatusBeforeRenew here - it is just compensating for the possibility of
the job not being run. On the Membership form we run it in preProcess but this feels like our first
chance in this form

Coments

The goal is to decommission the legacyProcessMembership function

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

CRM_Batch_Form_EntryTest::testMembershipRenewalDates
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'2021-07-16'
+'2016-04-01'

[eileenmcnaughton]

Interesting - tests are working then :-) I suspect the test might need fixing - will look

[eileenmcnaughton]

@colemanw this is passing now - it was a loop-leakage issue

[monishdeb]

Tested in local, r-run passed. Reviewed code looks good.