dev/core#2715 [REF] Start the process of moving financial processing to own class

[eileenmcnaughton]

Overview

[REF] Start the process of moving financial processing to own class

This starts the process of moving the functions used to process financial records to their own class

Once we have moved them over (& unwravelled all the 'self' references) it will be easier to clean them up
and use methods rather than param passing

Before

Function on one class

After

On another, less cluttered class

Technical Details

Not called from elsewhere

Comments

We don't need to do universe checks on these deep financial processing functions - we've been really clear that people shouldn't call them directly and they have changed many times

These are also heavily tested functions

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

test this please

[eileenmcnaughton]

@monishdeb or @colemanw - any chance you could merge this - I'll move over the other relevant static functions to that class & then start to make them non-static & interact in sane way

I'm hoping to fix testContributionFormStatusUpdates such that it passes validateAllPayments

[colemanw]

I checked & confirmed this function is only called from one place.