Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a typo in social networking buttons #20839

Merged
merged 1 commit into from
Jul 14, 2021

Conversation

in2part
Copy link

@in2part in2part commented Jul 13, 2021

Overview

Fix a typo in social networking buttons

Before

The LinkedIn url has a typo in the social network buttons template and not working.

After

The LinkedIn url has a correct url and is working.

Technical Details

The LinkedIn url has broken protocol in the url because of the typo.

Comments

The commit is made on behalf of Mads Mitchell ([email protected]). Please keep Mads Mitchell as a contributor of this fix.

@civicrm-builder
Copy link

Can one of the admins verify this patch?

@civibot
Copy link

civibot bot commented Jul 13, 2021

(Standard links)

@civibot civibot bot added the master label Jul 13, 2021
@eileenmcnaughton
Copy link
Contributor

Add to whitelist

@eileenmcnaughton
Copy link
Contributor

Thank you for the patch @in2part - can you please also submit an update to contributors.yml (in the root) - to add your details - (I don't know if the on behalf thing complicates it)

@seamuslee001 seamuslee001 merged commit 1f3f8af into civicrm:master Jul 14, 2021
@in2part
Copy link
Author

in2part commented Jul 14, 2021

@eileenmcnaughton Thanks for the reply. I wonder how I can add an update to the contributor-key.yml file and if I can add Mads Mitchell's details there (name, Github account). Do I just create another pull request?

@eileenmcnaughton
Copy link
Contributor

@in2part yep - add another pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants