Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enotice fix on extensions page #20801

Merged
merged 1 commit into from
Jul 16, 2021
Merged

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Jul 7, 2021

Overview

Enotice fix on extensions page

Before

image

After

image

Technical Details

I dug around and I think upgradable is an obsolete row value - I couldn't find where it
was set - including when I marked an extension as an older version in info.xml

Comments

@totten this is one of a bunch of notices on that page - I'm wondering if you would recognise some of the fields as dated if you looked (also I think it's OK for there to be notices if they are fields we think really should be filled in in the info.xml)

image

@civibot
Copy link

civibot bot commented Jul 7, 2021

(Standard links)

I dug around and I think upgradable is an obsolete row value - I couldn't find where it
was set - including when I marked an extension as an older version in info.xml
@demeritcowboy
Copy link
Contributor

demeritcowboy commented Jul 13, 2021

I agree that upgradable doesn't seem to be used anywhere - BUT - if you put a line <upgradable>1</upgradable> into your info.xml it does get picked up. Maybe it was an earlier way of flagging something.

@eileenmcnaughton
Copy link
Contributor Author

Hmm - maybe @totten can recall

@eileenmcnaughton
Copy link
Contributor Author

@demeritcowboy I suspect we won't get Tim's attention on this - but I think maybe we can treat this https://docs.civicrm.org/dev/en/latest/extensions/info-xml/ as authoritative about what is supported in info.xml

@demeritcowboy demeritcowboy merged commit 94f5195 into civicrm:master Jul 16, 2021
@eileenmcnaughton eileenmcnaughton deleted the upg branch July 16, 2021 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants