Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smarty notices - New case screen - Case.hlp #20795

Merged
merged 1 commit into from
Jul 7, 2021

Conversation

demeritcowboy
Copy link
Contributor

Overview

  1. Go to create a new case
  2. Smarty notices

Before

Notice: Undefined index: params in include() (line 11 of blah/0FA1A004%%Case.hlp.php

After

Technical Details

$params is sometimes legitimately missing, e.g. the way the access keys help bubble works it calls this file but without $params, or if you have the fulltext search drupal block enabled.

Comments

There are a couple side issues with this help bubble but am leaving out for now:

  1. The title of the subject help is just the generic "Title" - it should probably be "Subject".
  2. Do any of these help bubbles make sense on this page in the generic case? You can override them so it conveniently provides a pre-made spot to insert your own text and maybe people are doing that so I'm hesitant to just remove them, but maybe the default text could be something more generic.

@civibot
Copy link

civibot bot commented Jul 7, 2021

(Standard links)

@civibot civibot bot added the master label Jul 7, 2021
@colemanw colemanw merged commit 928af30 into civicrm:master Jul 7, 2021
@demeritcowboy demeritcowboy deleted the smartycasehlp branch July 7, 2021 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants