Handle participant payment create in line item #20790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove participant payment create from order api This is now done in the line item create & we went through to 'prove' that it works with extra validation
|
(Standard links)
|
monishdeb
reviewed
Jul 7, 2021
| if (!civicrm_api3('ParticipantPayment', 'getcount', $participantPaymentParams)) { | ||
| civicrm_api3('ParticipantPayment', 'create', $participantPaymentParams); | ||
| } | ||
| } |
There was a problem hiding this comment.
@eileenmcnaughton I was thinking to make these parts a bit generalised as I can few common pattern like:
...
$paymentEntites = CRM_Core_SelectValues::getPaymentEntites();
foreach ($paymentEntites as $entity => $paymentEntity) {
if ($lineItemBAO->entity_table == 'civicrm_' . $entity && $lineItemBAO->contribution_id && $lineItemBAO->entity_id) {
$entityParams = [
$entity . '_id' => $lineItemBAO->entity_id,
'contribution_id' => $lineItemBAO->contribution_id,
];
if (!civicrm_api3($paymentEntity, 'getcount', $entityParams)) {
$entityParams['isSkipLineItem'] = TRUE;
civicrm_api3($paymentEntity, 'create', $entityParams);
}
}
}There was a problem hiding this comment.
but in a separate PR, not blocker for this patch. Overall agree with the change.
There was a problem hiding this comment.
Yeah - if we get a use case (& tests) we can look at that. I don't want to be generic if there really are just 2 entities
|
Patch looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Handling participant payments the same way as membership payments - ie ensure they exist when the line item is created
Before
Done for membership payment in the line item bao but not participant payments
After
ALso for participant payments
Technical Details
Note the BAO handles the scenario where it already exists
Comments
@monishdeb this is pulled out from #20650 - the test in there shows it works but it needs #20670 merged first