Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smarty notice - confirm_message is usually irrelevant in report listings #20772

Merged
merged 1 commit into from
Jul 5, 2021

Conversation

demeritcowboy
Copy link
Contributor

Overview

Under Reports, visit any of the links, e.g. Contact Reports.

Before

Notice: Undefined index: confirm_message in include() (line 11 of ...\templates_c\en_US\%%93\93C\93C94F9B%%InstanceList.tpl.php).

After

Technical Details

confirm_message is usually only relevant for delete actions or some custom actions

Comments

Technically '0' is a valid string even if not a good message. I waffled a bit over whether to use isset, but which would then include the empty string.

@civibot
Copy link

civibot bot commented Jul 5, 2021

(Standard links)

@colemanw
Copy link
Member

colemanw commented Jul 5, 2021

Looks good.

@demeritcowboy
Copy link
Contributor Author

Thanks @colemanw

@monishdeb
Copy link
Member

Merging as per tag

@monishdeb monishdeb merged commit fdde44a into civicrm:master Jul 5, 2021
@demeritcowboy demeritcowboy deleted the smartyrep branch July 5, 2021 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants