Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smarty notice - title is only set for a list of existing report instances #20771

Merged
merged 1 commit into from
Jul 5, 2021

Conversation

demeritcowboy
Copy link
Contributor

Overview

Under Reports, visit any of the links, e.g. Contact Reports.

Before

Notice: Undefined index: title in ...\templates_c\en_US\%%93\93C\93C94F9B%%InstanceList.tpl.php on line 7

Note depending on your error settings it might appear in the accordion header not the usual drupal red error box area.

After

Technical Details

The title var is only set when you are viewing a list of existing instances created from a given template.

Also wrong use of ts placeholder.

There's an existing weird hack for Contribute, but I'm leaving that alone.

Comments

@civibot
Copy link

civibot bot commented Jul 5, 2021

(Standard links)

@civibot civibot bot added the master label Jul 5, 2021
@colemanw
Copy link
Member

colemanw commented Jul 5, 2021

Yuck, that was a real misuse of {ts}. Thanks for the fix.

@monishdeb
Copy link
Member

Merging as per tag

@monishdeb monishdeb merged commit eb9d477 into civicrm:master Jul 5, 2021
@demeritcowboy demeritcowboy deleted the smartyrep2 branch July 5, 2021 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants