dev/core#2115 Add test cover for membership type page #20761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
changed the title
eileenmcnaughton
force-pushed
the
mem_type
branch
3 times, most recently
from
3907223 to
93bdcc8
Compare
|
@colemanw wanna merge this? |
eileenmcnaughton
force-pushed
the
mem_type
branch
from
93bdcc8 to
0b123f1
Compare
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Jul 5, 2021
url is civicrm/admin/member/membershipType?reset=1 test cover in civicrm#20761
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Jul 5, 2021
url is civicrm/admin/member/membershipType?reset=1 test cover in civicrm#20761
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Jul 5, 2021
url is civicrm/admin/member/membershipType?reset=1 test cover in civicrm#20761
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Jul 5, 2021
url is civicrm/admin/member/membershipType?reset=1 test cover in civicrm#20761
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Jul 5, 2021
url is civicrm/admin/member/membershipType?reset=1 test cover in civicrm#20761
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Jul 5, 2021
url is civicrm/admin/member/membershipType?reset=1 test cover in civicrm#20761
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Jul 12, 2021
url is civicrm/admin/member/membershipType?reset=1 test cover in civicrm#20761
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add test cover for membership type page
Before
No test cover so we can't work on switching it to use v4 api / removing financial acl code
After
Cover added for the detail in core & the get call in the extension
Technical Details
Comments