Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing "View Recurring Contribution" link to contribution view #20750

Merged
merged 1 commit into from
Jul 2, 2021

Conversation

mattwire
Copy link
Contributor

@mattwire mattwire commented Jul 2, 2021

Overview

Add missing "View Recurring Contribution" link to contribution view when displaying line items.

Before

Lineitems:
image

No lineitems:
image

After

Lineitems:
image

No lineitems:
image

Technical Details

Comments

@jaapjansma Would you mind reviewing this one? I found it when reviewing #20399

@civibot
Copy link

civibot bot commented Jul 2, 2021

(Standard links)

@civibot civibot bot added the master label Jul 2, 2021
@mattwire mattwire changed the title Viewrecur Add missing "View Recurring Contribution" link to contribution view Jul 2, 2021
@jaapjansma
Copy link
Contributor

I cannot view the recurring contribution anymore on the contact summary. When I click --> Contributions --> recurring contributions the screen stays empty.

And I see this error on the contact summary. Not sure whether this is related.

Screenshot_20210702_172305

@mattwire
Copy link
Contributor Author

mattwire commented Jul 2, 2021

@jaapjansma I'm sorry! I left another commit in there too - would you mind trying again?

@jaapjansma
Copy link
Contributor

  • General standards
    • Explain (r-explain)
      • PASS : The goal/problem/solution have been adequately explained in the PR.
    • User impact (r-user)
      • PASS: The change would be intuitive or unnoticeable for a majority of users who work with this feature.
    • Documentation (r-doc)
      • PASS: The changes do not require documentation.
    • Run it (r-run)
      • PASS: I created a recurring contribution through the contribution page and viewed that recurring contribution
  • Developer standards
    • Technical impact (r-tech)
      • PASS: The change preserves compatibility with existing callers/code/downstream.
    • Code quality (r-code)
      • PASS: The functionality, purpose, and style of the code seems clear+sensible.
    • Maintainability (r-maint)
      • PASS: The change does not sufficiently improve test coverage, but special circumstances make it important to accept the change anyway.
    • Test results (r-test)
      • PASS: The test results are all-clear. At least on the previous run, now the tests are still running.

@jaapjansma
Copy link
Contributor

I feel comfortable that this gets merged as soon as the tests are finished and ok

@mattwire mattwire merged commit 7206974 into civicrm:master Jul 2, 2021
@mattwire
Copy link
Contributor Author

mattwire commented Jul 2, 2021

Merging based on @jaapjansma review

@mattwire mattwire deleted the viewrecur branch July 2, 2021 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants