dev/core#2660 - Remove old menu entry for "New Tag"

[demeritcowboy]

Overview

https://lab.civicrm.org/dev/core/-/issues/2660

Before

1. Contact -> New Tag.
2. It goes to the same place as Manage Tags.

After

No practical change.

Technical Details

This seems to be left over from when the tags screen was redone. There is a real "new tag" url, but it's a different url and on the manage tags screen you have more options like parents or tagsets, so since people are already going to that screen in practice they aren't losing anything.

Comments

Only for new installs.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

Looks good @demeritcowboy
On an administrative note, you can have this PR automatically close the issue by putting "Fixes dev/core#2660" in the commit message (not the PR, has to be the actual commit msg)

[demeritcowboy]

Ok thanks noted - although I'd still want to go put in the milestone. It's probably not simple to have it do that automatically.

[demeritcowboy]

Interesting - there's only one record in the civicrm_contact table. Hmm.

[demeritcowboy]

I see what it is. The regen script needs updating, for fantastic reasons which the margins here are too small to contain.

[colemanw]

Goodbye old new tag