dev/core#2645 Proposed fix for exporting preferred_mail_format field #20626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
(Standard links)
|
|
test this please |
|
Jenkins add to whitelist |
|
@akosgarai Can you please squash the commits? |
A localized value for this field does not fit into the original varchar(8) dev/core#2645 Update testcases
|
The commits have been sqashed @yashodha |
|
@akosgarai Thanks! |
kcristiano
added a commit
to tadpolecc/civicrm
that referenced
this pull request
Nov 4, 2021
Signed-off-by: Kevin Cristiano <[email protected]>
kcristiano
added a commit
to tadpolecc/civicrm
that referenced
this pull request
Nov 4, 2021
Signed-off-by: Kevin Cristiano <[email protected]>
kcristiano
added a commit
to tadpolecc/civicrm
that referenced
this pull request
Nov 4, 2021
Signed-off-by: Kevin Cristiano <[email protected]>
kcristiano
added a commit
to tadpolecc/civicrm
that referenced
this pull request
Nov 4, 2021
Signed-off-by: Kevin Cristiano <[email protected]>
kcristiano
added a commit
to tadpolecc/civicrm
that referenced
this pull request
Nov 15, 2021
Signed-off-by: Kevin Cristiano <[email protected]>
kcristiano
added a commit
to tadpolecc/civicrm
that referenced
this pull request
Nov 15, 2021
Signed-off-by: Kevin Cristiano <[email protected]>
kcristiano
added a commit
to tadpolecc/civicrm
that referenced
this pull request
Dec 4, 2021
Signed-off-by: Kevin Cristiano <[email protected]>
kcristiano
added a commit
to tadpolecc/civicrm
that referenced
this pull request
Jan 7, 2022
Signed-off-by: Kevin Cristiano <[email protected]>
kcristiano
added a commit
to tadpolecc/civicrm
that referenced
this pull request
Jan 7, 2022
Signed-off-by: Kevin Cristiano <[email protected]>
kcristiano
added a commit
to tadpolecc/civicrm
that referenced
this pull request
Jan 12, 2022
Signed-off-by: Kevin Cristiano <[email protected]>
kcristiano
added a commit
to tadpolecc/civicrm
that referenced
this pull request
Jan 12, 2022
Signed-off-by: Kevin Cristiano <[email protected]>
kcristiano
added a commit
to tadpolecc/civicrm
that referenced
this pull request
Jan 29, 2022
Signed-off-by: Kevin Cristiano <[email protected]>
kcristiano
added a commit
to tadpolecc/civicrm
that referenced
this pull request
Jan 29, 2022
Signed-off-by: Kevin Cristiano <[email protected]>
kcristiano
added a commit
to tadpolecc/civicrm
that referenced
this pull request
Feb 4, 2022
Signed-off-by: Kevin Cristiano <[email protected]>
kcristiano
added a commit
to tadpolecc/civicrm
that referenced
this pull request
Feb 4, 2022
Signed-off-by: Kevin Cristiano <[email protected]>
kcristiano
added a commit
to tadpolecc/civicrm
that referenced
this pull request
Feb 4, 2022
Signed-off-by: Kevin Cristiano <[email protected]>
kcristiano
added a commit
to tadpolecc/civicrm
that referenced
this pull request
Feb 4, 2022
Signed-off-by: Kevin Cristiano <[email protected]>
kcristiano
added a commit
to tadpolecc/civicrm
that referenced
this pull request
Feb 9, 2022
Signed-off-by: Kevin Cristiano <[email protected]>
kcristiano
added a commit
to tadpolecc/civicrm
that referenced
this pull request
Feb 9, 2022
Signed-off-by: Kevin Cristiano <[email protected]>
kcristiano
added a commit
to tadpolecc/civicrm
that referenced
this pull request
Aug 4, 2022
Signed-off-by: Kevin Cristiano <[email protected]>
kcristiano
added a commit
to tadpolecc/civicrm
that referenced
this pull request
Aug 9, 2022
Signed-off-by: Kevin Cristiano <[email protected]>
kcristiano
added a commit
to tadpolecc/civicrm
that referenced
this pull request
Aug 13, 2022
Signed-off-by: Kevin Cristiano <[email protected]>
kcristiano
added a commit
to tadpolecc/civicrm
that referenced
this pull request
Aug 31, 2022
Signed-off-by: Kevin Cristiano <[email protected]>
kcristiano
added a commit
to tadpolecc/civicrm
that referenced
this pull request
Sep 8, 2022
Signed-off-by: Kevin Cristiano <[email protected]>
kcristiano
added a commit
to tadpolecc/civicrm
that referenced
this pull request
Oct 9, 2022
Signed-off-by: Kevin Cristiano <[email protected]>
kcristiano
added a commit
to tadpolecc/civicrm
that referenced
this pull request
Oct 28, 2022
Signed-off-by: Kevin Cristiano <[email protected]>
kcristiano
added a commit
to tadpolecc/civicrm
that referenced
this pull request
Nov 3, 2022
Signed-off-by: Kevin Cristiano <[email protected]>
kcristiano
added a commit
to tadpolecc/civicrm
that referenced
this pull request
Nov 8, 2022
Signed-off-by: Kevin Cristiano <[email protected]>
kcristiano
added a commit
to tadpolecc/civicrm
that referenced
this pull request
Nov 18, 2022
Signed-off-by: Kevin Cristiano <[email protected]>
kcristiano
added a commit
to tadpolecc/civicrm
that referenced
this pull request
Dec 9, 2022
Signed-off-by: Kevin Cristiano <[email protected]>
kcristiano
added a commit
to tadpolecc/civicrm
that referenced
this pull request
Dec 21, 2022
Signed-off-by: Kevin Cristiano <[email protected]>
kcristiano
added a commit
to tadpolecc/civicrm
that referenced
this pull request
Jan 5, 2023
Signed-off-by: Kevin Cristiano <[email protected]>
kcristiano
added a commit
to tadpolecc/civicrm
that referenced
this pull request
Jan 5, 2023
Signed-off-by: Kevin Cristiano <[email protected]>
kcristiano
added a commit
to tadpolecc/civicrm
that referenced
this pull request
Jan 12, 2023
Signed-off-by: Kevin Cristiano <[email protected]>
kcristiano
added a commit
to tadpolecc/civicrm
that referenced
this pull request
Jan 26, 2023
Signed-off-by: Kevin Cristiano <[email protected]>
kcristiano
added a commit
to tadpolecc/civicrm
that referenced
this pull request
Jan 31, 2023
Signed-off-by: Kevin Cristiano <[email protected]>
kcristiano
added a commit
to tadpolecc/civicrm
that referenced
this pull request
Feb 2, 2023
Signed-off-by: Kevin Cristiano <[email protected]>
kcristiano
added a commit
to tadpolecc/civicrm
that referenced
this pull request
Feb 16, 2023
Signed-off-by: Kevin Cristiano <[email protected]>
kcristiano
added a commit
to tadpolecc/civicrm
that referenced
this pull request
Mar 2, 2023
Signed-off-by: Kevin Cristiano <[email protected]>
kcristiano
added a commit
to tadpolecc/civicrm
that referenced
this pull request
Mar 6, 2023
Signed-off-by: Kevin Cristiano <[email protected]>
kcristiano
added a commit
to tadpolecc/civicrm
that referenced
this pull request
Mar 11, 2023
Signed-off-by: Kevin Cristiano <[email protected]>
kcristiano
added a commit
to tadpolecc/civicrm
that referenced
this pull request
Mar 16, 2023
Signed-off-by: Kevin Cristiano <[email protected]>
kcristiano
added a commit
to tadpolecc/civicrm
that referenced
this pull request
Mar 28, 2023
Signed-off-by: Kevin Cristiano <[email protected]>
kcristiano
added a commit
to tadpolecc/civicrm
that referenced
this pull request
Apr 6, 2023
Signed-off-by: Kevin Cristiano <[email protected]>
kcristiano
added a commit
to tadpolecc/civicrm
that referenced
this pull request
May 4, 2023
Signed-off-by: Kevin Cristiano <[email protected]>
kcristiano
added a commit
to tadpolecc/civicrm
that referenced
this pull request
May 6, 2023
Signed-off-by: Kevin Cristiano <[email protected]>
kcristiano
added a commit
to tadpolecc/civicrm
that referenced
this pull request
May 16, 2023
Signed-off-by: Kevin Cristiano <[email protected]>
kcristiano
added a commit
to tadpolecc/civicrm
that referenced
this pull request
May 20, 2023
Signed-off-by: Kevin Cristiano <[email protected]>
kcristiano
added a commit
to tadpolecc/civicrm
that referenced
this pull request
May 24, 2023
Signed-off-by: Kevin Cristiano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
A patch for CORE-2645
Exporting in localized civicrm crashes due to long translation for preferred_mail_format varchar(8) field.
Before
Export of all contact data with at least one contact with preferred_mail_format 'Both' in Hungary l10n crashes with
Data too long for column 'preferred_mail_format'exception.After
The export works again, the csv is downloadable.
Technical Details
The preferred_mail_format is varchar(8) by default, but it is not long enough for the Hungarian translation, so that it has been changed to varchar(16), that is enough long for the translated string.