[php8-compact] Further test fixes for php8 #20597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
| @@ -32,7 +32,7 @@ | |||
| {/if} | |||
|
|
|||
| {* Add all the form elements sent in by the hook - formerly used by civiDiscount, now deprecated*} | |||
| {if $beginHookFormElements} | |||
| {if !empty($beginHookFormElements)} | |||
There was a problem hiding this comment.
I was going to suggest that as per the code comment to maybe do something else, but the code comment isn't right anymore since the deprecation was reverted in civicrm/org.civicrm.module.cividiscount#254. And also it looks like it's used in a small handful of other extensions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes the following 2 issues
Undefined array key "beginHookFormElements"
/home/jenkins/bknix-edge/build/build-0/web/sites/default/files/civicrm/templates_c/en_US/%%4D/4DC/4DC76B26%%body.tpl.php:36
Required parameter $attributes follows optional parameter $from
/home/jenkins/bknix-edge/build/build-0/web/sites/all/modules/civicrm/CRM/Core/Form/Date.php:164
Before
Those 2 tests fail on php8
After
Those 2 tests pass on php8
ping @eileenmcnaughton @demeritcowboy @totten @colemanw