APIv4 - Add filter for entity tags #20573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
Test Result (9 failures / +9) |
|
Upgrade and code makes sense but clearly there is some issues around the used_for criteria field |
colemanw
force-pushed
the
entityTagFilter
branch
from
c861421 to
b24fa2a
Compare
|
I added legacy handling to |
|
@colemanw I tried this out on the PR test site but in both the APIv4 Explorer and in search kit I wasn't seeing the tags filter am I missing something?
|
|
I see the problem. |
colemanw
force-pushed
the
entityTagFilter
branch
from
fc1b43f to
b74b830
Compare
|
I was able to do it myself thanks to @demeritcowboy's brilliant new github action https://github.com/demeritcowboy/civicrm-regen |
colemanw
force-pushed
the
entityTagFilter
branch
from
25adf6f to
a6d0f90
Compare
|
@colemanw I tried on the test site and I created a test child tag that was a child of volunteer and then tried with tags:name or tags = Test Child Tag and it got the following error Then i tried changing the operator to be IN with field = tags However doing IN with field tags:name worked and this was all done in the APIv4 Explorer |
|
@seamuslee001 the API explorer is more open ended and allows you to screw stuff up. Try SearchKit it restricts the operator and normalizes the input for you. |
|
Ok it works fine in Search Kit, I figure that it probably should be tied up in the Explorer but that can be a follow up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds a SearchKit/APIv4 filter for tags similar to the "groups" filter recently added to SearchKit.
Before
No filter to search for Contacts/Activities/Cases/etc. by tag.
After
Filter is added to all taggable entities. Finds records with or without particular tag(s). Searching on a parent tag will find records with child tags.
Technical Details
I updated the
tag_used_foroption group to fix a couple issues with it: