dev/core#2642 Add filter by custom fields in Accounting Batch

[muniodiego]

Overview

When filtering transactions to be included in a batch, custom field filters do not work.

Comments

Issue: https://lab.civicrm.org/dev/core/-/issues/2642

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

Test fail relates here

CRM_Financial_Page_AjaxTest::testGetFinancialTransactionsList
Invalid argument supplied for foreach()

/home/jenkins/bknix-dfl/build/core-20556-3fg6v/web/sites/all/modules/civicrm/CRM/Batch/BAO/Batch.php:708

[muniodiego]

@seamuslee001 , Bug fixed.

[demeritcowboy]

• General standards
  • [r-explain] PASS
  • [r-user] PASS
  • [r-doc] PASS
  • [r-run] PASS
    • Did a light run.
• Developer standards
  • [r-tech] PASS
  • [r-code] Just needs a squash
    • Can you squash commits?
    • Just making a note that at line 776 the existing code calls CRM_Contact_BAO_Query and the second parameter can include custom fields by just setting the defaultReturnProperties() second parameter to TRUE, however the rest of this batch function doesn't really use the query except for some minor where clause manipulation, so changing it to TRUE doesn't help much and you still need to build the query.
  • [r-maint] ?
    • A test would be nice. It's a public static function so in theory shouldn't depend on too much setup.
  • [r-test] PASS

[demeritcowboy]

@muniodiego Are you able to squash commits and perhaps add a unit test?

[demeritcowboy]

Thanks for updating. I'm going to merge.