[REF] Extend testing on membership batch entry & minor cleanup #20394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
| // retrieve 'from email id' for acknowledgement | ||
| $receiptFrom = $formValues['from_email_address'] ?? NULL; | ||
|
|
||
| protected function emailReceipt($form, &$formValues, $membership): bool { |
There was a problem hiding this comment.
emailReceipt was copied here from another class recently so we know it's not called elsewhere
This extends the cover on the batch entry test (by doing post test validation) and does a minor extraction on the getDomainEmail address
This was referenced Jun 4, 2021
|
@monishdeb are you able to review / merge this and the related one #20396 ? |
|
Tested on local, works fine. Code changes look good. Merging now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This extends the cover on the batch entry test (by doing post test validation) and does a minor
extraction on the getDomainEmail address
Before
Duplicated code & param passed around
After
Replaced by a function call
Technical Details
Other forms use more nuanced from addresses - out of scope here but this would make it easier to update
Comments